-
Notifications
You must be signed in to change notification settings - Fork 7.7k
vale: add "BGP" (Border Gateway Protocol) to acronyms #22731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -17,6 +17,7 @@ exceptions: | |||
- ASP | |||
- AUFS | |||
- AWS | |||
- BGP # Border Gateway Protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, wondering now if vale failed to detect how it was used, because the acronym was not on the same line 🤔
Docker host. This can be achieved using static routes, Border Gateway Protocol
(BGP), or any other means appropriate for your network. For example, within
I wonder if it would be OK with it used if it was on the same line;
Docker host. This can be achieved using static routes, Border Gateway Protocol (BGP),
or any other means appropriate for your network. For example, within
docs/_vale/Docker/Acronyms.yml
Lines 3 to 10 in dc01252
link: https://docs.docker.com/contribute/style/grammar/#acronyms-and-initialisms | |
level: warning | |
ignorecase: false | |
# Ensures that the existence of 'first' implies the existence of 'second'. | |
first: '\b([A-Z]{2,5})\b' | |
second: '(?:\b[A-Z][a-z]+ )+\(([A-Z]{2,5})s?\)' | |
# ... with the exception of these: | |
exceptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that regex needs tweaking to take newlines into account (in addition to spaces 🤔)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - putting it on the same line sorted it.
Description
Related issues or tickets
Reviews