Skip to content

vale: add "BGP" (Border Gateway Protocol) to acronyms #22731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link

netlify bot commented May 30, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d82fd15
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6839a30c4f27d80008fae980
😎 Deploy Preview https://deploy-preview-22731--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -17,6 +17,7 @@ exceptions:
- ASP
- AUFS
- AWS
- BGP # Border Gateway Protocol
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, wondering now if vale failed to detect how it was used, because the acronym was not on the same line 🤔

Docker host. This can be achieved using static routes, Border Gateway Protocol
(BGP), or any other means appropriate for your network. For example, within

I wonder if it would be OK with it used if it was on the same line;

Docker host. This can be achieved using static routes, Border Gateway Protocol (BGP),
or any other means appropriate for your network. For example, within

link: https://docs.docker.com/contribute/style/grammar/#acronyms-and-initialisms
level: warning
ignorecase: false
# Ensures that the existence of 'first' implies the existence of 'second'.
first: '\b([A-Z]{2,5})\b'
second: '(?:\b[A-Z][a-z]+ )+\(([A-Z]{2,5})s?\)'
# ... with the exception of these:
exceptions:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that regex needs tweaking to take newlines into account (in addition to spaces 🤔)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - putting it on the same line sorted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants