Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hugo includes rendering bug #21943

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Jan 31, 2025

Description

  • There is a bug in Hugo that is not parsing includes that begin with a shortcode correctly
  • The fix here replaces the admin-early-access.md include with our summary bar solution
  • Summary bar shortcode updated to support text in the availability field, this will allow us more flexibility with customizing this field while still supporting the iconography
  • NOTE: We will not be able to add the summary bar inside {{tab}}/{{tabs}} layouts because it messes up the rendering

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 39fcfad
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/679d0b6c5280ba00089ec6bc
😎 Deploy Preview https://deploy-preview-21943--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/security area/admin Relates to Docker Admin hugo Updates related to hugo labels Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6d05786
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/679d21273cb28d000823374c
😎 Deploy Preview https://deploy-preview-21943--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craig-osterhout
Copy link
Contributor

craig-osterhout commented Jan 31, 2025

Just noting that the callouts in http://deploy-preview-21943--docsdocker.netlify.app/admin/company/users/ are unusual. Not caused by this PR.
The admin early access callout is on the one section that doesn't reference admin, while the other sections do reference admin and don't have a callout.

@sarahsanders-docker
Copy link
Contributor Author

Just noting that the callouts in http://deploy-preview-21943--docsdocker.netlify.app/admin/company/users/ are unusual. Not caused by this PR. The admin early access callout is on the one section that doesn't reference admin, while the other sections do reference admin and don't have a callout.

oh yeah that is odd!! I went ahead and removed the summary bar from that section

@sarahsanders-docker sarahsanders-docker merged commit 61fa434 into docker:main Jan 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin Relates to Docker Admin area/security hugo Updates related to hugo status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants