Skip to content

Conversation

chaomonica
Copy link
Contributor

@chaomonica chaomonica commented Jan 3, 2025

Description

Based on customer feedback, it was not clear how to resolve the unable to create symbolic link error which can result from a user without permissions to create symbolic links when using a synchronized file share.

Related issues or tickets

  • SEG-689

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1e1f6b2
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/677c026a26f5700007490d6f
😎 Deploy Preview https://deploy-preview-21712--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@steph-docker steph-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chaomonica chaomonica marked this pull request as ready for review January 3, 2025 22:33
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chaomonica. 2 style guide phrasing nits and a 2 questions


If your user does not have permissions to create symbolic links and your container attempts to create symbolic links in your file share instance, a **Problem** indicator with an `unable to create symbolic link` error will result.

See [Create symbolic links](https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-10/security/threat-protection/security-policy-settings/create-symbolic-links) for best practices and location of the "Create symbolic links" security policy setting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just an issue for Windows users? Is there an equivalent docs set for Mac users we can add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker This is just an issue for Windows users and there is no equivalent docs set for Mac users. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaomonica ok great, so in that case, we should make that clear. Perhaps adapting the first sentence with 'As a Windows user, if you don't have the correct permissions......etc'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker Oops, actually my mistake - let me actually test this on Mac.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker I have added an additional sentence for Linux and Mac users. Thank you for checking!

@@ -80,6 +80,12 @@ Some example of things you might want to add to your `.syncignore` file are:

In general, use your `.syncignore` file to exclude items that aren't critical to your workflow, especially those that would be slow to sync or use significant storage.

## Symbolic links
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a new section, I think it'd be better to have this as a bullet point in the 'Known issues' section below. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aevesdocker I will format this into a bullet point. Thank you for pointing this out!

chaomonica and others added 4 commits January 6, 2025 09:22
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @chaomonica! LGTM!

@aevesdocker aevesdocker merged commit 66eb22e into docker:main Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants