engine: dynamic docker-ce version n (latest) and n-1 #21599
Conversation
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| latest_engine_api_version: "1.47" | ||
| docker_ce_version: "27.4.0" | ||
| docker_ce_version_prev: "27.3.1" |
There was a problem hiding this comment.
Do you think we need to add comments to describe what they're used for?
There was a problem hiding this comment.
would probably be good to add more comments, generally. There's quite a bit of config here. Will do in a followup
There was a problem hiding this comment.
Maybe even restructure the config. It's all in one file now, but we could use a config directory with different files for params, general config, menus, etc.
There was a problem hiding this comment.
Yeah, perhaps splitting could work, although it's not super large, so still somewhat OK (perhaps splitting taxonomy, params could make sense though).
Comments would be good; I think currently for some of these parameters it's clear what it "is", but not what it's for (or intended to be used for)
Makes it just a little bit easier to update in the future.