Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java containerization guide to fix compilation error #21283

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

swivelmargarita
Copy link
Contributor

Fixes #21281

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9fd26fc
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672214a89f75e500080d6804
😎 Deploy Preview https://deploy-preview-21283--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you ptal @falconcr ?

@falconcr
Copy link
Contributor

LGTM, can you ptal @falconcr ?

LGTM, it is interesting because using the jre also works but move to use jdk instead. @dvdksn

@dvdksn dvdksn merged commit 4494558 into docker:main Oct 30, 2024
14 checks passed
@swivelmargarita
Copy link
Contributor Author

swivelmargarita commented Oct 30, 2024

Thanks for the merge.

LGTM, it is interesting because using the jre also works but move to use jdk instead. @dvdksn

What I've found seems interesting. Dockerfile from the next page of that guide uses jdk tag already instead of jre tag.

Even though this merge solves a possible nonexistent problem, it helps with the consistency of the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building the spring pet clinic app using the Dockerfile from java guides results in error
3 participants