Merged
Conversation
Original: on line 18 we have `images, err := cli.ImageList(context.Background(), types.ImageListOptions{})` which gives us an error of:
```
# command-line-arguments
./main.go:12:2: ctx declared but not used
```
*Fix:* on line 18 we need to have `images, err := cli.ImageList(ctx, types.ImageListOptions{})`
|
Deploy preview for docsdocker ready! Built with commit 6f38ea5 |
Member
|
Thank you for the update @andrealmar. @thaJeztah Could you PTAL? |
thaJeztah
approved these changes
Jun 30, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
yes, that looks good, thanks!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original: on line 18 we have
images, err := cli.ImageList(context.Background(), types.ImageListOptions{})which gives us an error of:Proposed changes
Fix: on line 18 we need to have
images, err := cli.ImageList(ctx, types.ImageListOptions{})in order to fix the error outlined above
Unreleased project version (optional)
Related issues (optional)