Skip to content

Docs for Windows Home support and QSG #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2020

Conversation

usha-mandya
Copy link
Member

  • Added a new topic to describe the pre-reqs and installation instructions for Windows Home.
  • Updated installation instructions on Windows/Mac topics
  • Removed references to Toolbox from the Install topics
  • Updated the Install pages to add info on the new onboarding tutorial on startup

@netlify
Copy link

netlify bot commented Apr 20, 2020

Deploy preview for docsdocker ready!

Built with commit f46a982

https://deploy-preview-10669--docsdocker.netlify.app

@usha-mandya
Copy link
Member Author

Need to add the download URLs to the Windows Home topic when the build # is confirmed.

@nebuk89
Copy link
Contributor

nebuk89 commented Apr 21, 2020

Looks good to me, we should get @simonferquel to have a look as someone who has installed it on Windows home 👍

@usha-mandya
Copy link
Member Author

Sure. @simonferquel Could you PTAL?

I've tried the installation on a Windows Home test machine set up by Stefan. Let me know if there are any steps/caveats missing.

Copy link
Contributor

@simonferquel simonferquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes required

…e machines.

- Update installation instructions on Windows/Mac topics
- Removed references to Toolbox from the Install topics
- Updated the Install pages to add info on the new onboarding tutorial on startup
@usha-mandya usha-mandya marked this pull request as draft April 22, 2020 11:12
@usha-mandya
Copy link
Member Author

Converting to 'Draft' due to the new timelines.

@usha-mandya usha-mandya marked this pull request as ready for review April 24, 2020 14:16
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions.

usha-mandya and others added 6 commits May 10, 2020 21:01
Co-authored-by: Stefan Scherer <stefan.scherer@docker.com>
Co-authored-by: Stefan Scherer <stefan.scherer@docker.com>
Co-authored-by: Stefan Scherer <stefan.scherer@docker.com>
Co-authored-by: Stefan Scherer <stefan.scherer@docker.com>
@usha-mandya usha-mandya requested a review from StefanScherer May 10, 2020 20:16
@usha-mandya
Copy link
Member Author

@StefanScherer PTAL

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit a9a6c22 into docker:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants