[18.03 backport] fetch resources use tags#10349
Merged
usha-mandya merged 18 commits intodocker:v18.03from Feb 26, 2020
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit b35c875) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit f3feee5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When using Gnu Wget, the `--directory-prefix` option automatically creates the specified path if it doesn't exist. Note that this does not work when using the busybox version of Wget (but we're not using that in our Dockerfile). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3f165c6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d386c4c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This variable is no longer needed, as the scripts are always executed relative to the current directory (`.`). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5d8ce07) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Add a `--quiet` flag to suppress progress output; ``` --2019-03-07 14:02:43-- https://raw.githubusercontent.com/docker/docker-ce/17.12/components/engine/api/swagger.yaml Resolving raw.githubusercontent.com... 151.101.0.133, 151.101.64.133, 151.101.128.133, ... Connecting to raw.githubusercontent.com|151.101.0.133|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 343126 (335K) [text/plain] Saving to: './engine/api/v1.35/swagger.yaml' 0K .......... .......... .......... .......... .......... 14% 2.97M 0s 50K .......... .......... .......... .......... .......... 29% 6.10M 0s 100K .......... .......... .......... .......... .......... 44% 6.22M 0s 150K .......... .......... .......... .......... .......... 59% 6.32M 0s 200K .......... .......... .......... .......... .......... 74% 6.15M 0s 250K .......... .......... .......... .......... .......... 89% 6.11M 0s 300K .......... .......... .......... ..... 100% 6.82M=0.06s 2019-03-07 14:02:44 (5.37 MB/s) - './engine/api/v1.35/swagger.yaml' saved [343126/343126] ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0785a85) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit f297c55) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d2504d3) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 449d7c6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit dc3c434) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit a0c6b80) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5e3415c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1b63746) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8385091) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit c7d08f8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e6c6560) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 80e46fe) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
35 tasks
usha-mandya
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #10101 and related changes
I tested this locally with
DOCKER_BUILDKIT=0, because theonbuildbase image we're using in the archives don't seem to work well with buildkit enabled.Given that backporting these changes is not trivial, I think we should skip the other archives, and accept them to be potentially "broken" (existing images on docker hub remain to work, but rebuilding them might not always be possible)