Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
  • Loading branch information
@vvoland @dvdksn
vvoland and dvdksn authored Jan 13, 2025
1 parent ccee1a2 commit 3306897
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions content/manuals/engine/release-notes/27.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ For a full list of pull requests and changes in this release, refer to the relev
#### Bugfixes and enhancements

- containerd image store: Fix passing a build context via tarball to the `/build` endpoint. [moby/moby#49194](https://github.com/moby/moby/pull/49194)
- Builder GC policies without a `keepStorage` value now inherit the `defaultKeepStorage` limit as intended. [moby/moby#49137](https://github.com/moby/moby/pull/49137)
- Builder garbage collection policies without a `keepStorage` value now inherit the `defaultKeepStorage` limit as intended. [moby/moby#49137](https://github.com/moby/moby/pull/49137)
- Preserve network labels during daemon startup. [moby/moby#49200](https://github.com/moby/moby/pull/49200)
- Fix a potential race condition error when deleting a container. [moby/moby#49239](https://github.com/moby/moby/pull/49239)

#### Removed
#### Go SDK

- Go SDK: pkg/sysinfo: deprecate NumCPU. This utility has the same behavior as runtime.NumCPU. [moby/moby#49247](https://github.com/moby/moby/pull/49247)
- Go SDK: pkg/fileutils: deprecate GetTotalUsedFds: this function is only used internally and will be removed in the next release. [moby/moby#49209](https://github.com/moby/moby/pull/49209)
- Go SDK: pkg/ioutils: deprecate `BytesPipe`, `NewBytesPipe`, `ErrClosed`, `WriteCounter`, `NewWriteCounter`, `NewReaderErrWrapper`, `NopFlusher`, `NopWriter`, `NopWriteCloser`. They were only used internally and will be removed in the next release. [moby/moby#49246](https://github.com/moby/moby/pull/49246), [moby/moby#49255](https://github.com/moby/moby/pull/49255)
- pkg/reexec: deprecate and migrate to github.com/moby/sys/reexec. This package is deprecated and moved to a separate module. Use github.com/moby/sys/reexec instead. [moby/moby#49135](https://github.com/moby/moby/pull/49135)
- `pkg/sysinfo`: deprecate `NumCPU`. This utility has the same behavior as runtime.NumCPU. [moby/moby#49247](https://github.com/moby/moby/pull/49247)
- `pkg/fileutils`: deprecate `GetTotalUsedFds`: this function is only used internally and will be removed in the next release. [moby/moby#49209](https://github.com/moby/moby/pull/49209)
- `pkg/ioutils`: deprecate `BytesPipe`, `NewBytesPipe`, `ErrClosed`, `WriteCounter`, `NewWriteCounter`, `NewReaderErrWrapper`, `NopFlusher`, `NopWriter`, `NopWriteCloser`. They were only used internally and will be removed in the next release. [moby/moby#49246](https://github.com/moby/moby/pull/49246), [moby/moby#49255](https://github.com/moby/moby/pull/49255)
- `pkg/reexec`: deprecate and migrate to `github.com/moby/sys/reexec`. This package is deprecated and moved to a separate module. Use github.com/moby/sys/reexec instead. [moby/moby#49135](https://github.com/moby/moby/pull/49135)

Check failure on line 51 in content/manuals/engine/release-notes/27.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'GitHub( Actions)?' instead of 'github'.

Raw Output:
{"message": "[Vale.Terms] Use 'GitHub( Actions)?' instead of 'github'.", "location": {"path": "content/manuals/engine/release-notes/27.md", "range": {"start": {"line": 51, "column": 135}}}, "severity": "ERROR"}

#### Packaging updates
- Update containerd to [v1.7.25](https://github.com/containerd/containerd/releases/tag/v1.7.25) [moby/moby#49253](https://github.com/moby/moby/pull/49253)
Expand Down

0 comments on commit 3306897

Please sign in to comment.