This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Use the official docker api library #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 18, 2017 12:19
This is the tool being used in other docker repos these days. Signed-off-by: Dave Tucker <dt@docker.com>
Signed-off-by: Dave Tucker <dt@docker.com>
Signed-off-by: Dave Tucker <dt@docker.com>
dave-tucker
changed the title
|
Investigation didn't lead anywhere but I don't think this PR make it any worse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
docker/clientinstead of the un-official library.This should be always up-to-date 🎉
Tagged as WIP as I found a bug where all of your containers get nuked 😮
I believed this could have been API related but so far it appears to be some derpiness in the LUA code.
I suspect I'm to blame, so tracking it down... and hope to fix before merging this PR