This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Cleaner Cuberite integration and world customizations #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 8, 2016 18:05
Signed-off-by: Dave Tucker <dt@docker.com>
This should never have been checked in Signed-off-by: Dave Tucker <dt@docker.com>
I noticed some weird things happening after I'd changed to using a newly generated world. Namely, the WorldStarted hook was being triggered *after* the updates for other containers had already been queued! To fix this I: - Made all ground drawing happen in addGround - Changed the update queue to be a more traditional strict queue - This has the added benefit that we can check the length easily - Removed unused hooks - WorldStarted and OnChunkGenerated Signed-off-by: Dave Tucker <dt@docker.com>
The lua code was a mess of mixed indentation and trailing spaces. Using ZeroBraneStudio correct indentation and vim, this is now fixed. We should aspire to keep it tidier Signed-off-by: Dave Tucker <dt@docker.com>
Signed-off-by: Dave Tucker <dt@docker.com>
|
One final implementation note... I adjusted the I also seemed to be hitting a bug with Docker 1.13 RC3 - occasionally the container info didn't make it back and/or we were dropping block updates. This manifested as missing text on signs. |
Signed-off-by: Dave Tucker <dt@docker.com>
|
Merging as master won't build due to new Cuberite runtime requirements (some missing |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #71 and #54
The cuberite integration has been cleaned up so we now no longer have overlapping code.
To bump the cuberite version, we just increment the build number in the Dockerfile.
While cleaning this up, I took the liberty of adjusting the
world.inito generate an empty world instead of having one checked in to the repo.The empty world was a little too empty for my liking, so I changed the config to generate a flat world underneath the containers.
This also reduced the complexity of the plugin code while also adding a new feature...
Introducing Customizations 🎉
You can transport your containers from the Plains to any other Biome of your choosing.
There are some examples of how to do this in the README along with images.
Oh, and if you are longing for the vanilla Dockercraft experience, you can use the
Skybiome 😀Additional minor fixes: