hotfix: pin urllib3 version to < 2#3114
Closed
wadhah101 wants to merge 1 commit intodocker:mainfrom
wadhah101:wadhah/fix-urllib3-version
Closed
hotfix: pin urllib3 version to < 2#3114wadhah101 wants to merge 1 commit intodocker:mainfrom wadhah101:wadhah/fix-urllib3-version
wadhah101 wants to merge 1 commit intodocker:mainfrom
wadhah101:wadhah/fix-urllib3-version
Conversation
rafaelgieschke
referenced
this pull request
in emulation-as-a-service/eaas-installer
Apr 30, 2023
Contributor
|
You should also restrict |
Author
|
@felixfontein Can you provide any examples ? The ci in my repo seems to be passing https://github.com/wadhah101/docker-py/pull/1 |
Contributor
Author
|
#3116 does a better job |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3113
Urllib3 v2 have introduced some breaking changes. The easiest fix for now to pin the package to
< 2.Another issue for upgrading Urllib3 must be added.