Skip to content

Add support for jumping to Dockerfile from Compose file's dockerfile attribute #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pletea-Marinescu-Valentin

This pull request implements the feature to allow jumping to a Dockerfile from a Compose file's dockerfile attribute inside the build specification. It addresses the issue where navigating to the referenced Dockerfile was not supported.

Changes:

  • Updated the DocumentLink function to parse Compose files and resolve dockerfile attributes.

  • Added test cases to verify the functionality for dockerfile attributes in the build section.

Issue Reference
Closes #69

Copy link
Collaborator

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. From what I can see, this change breaks the existing tests. Do you see the same result on your end?

Co-authored-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Pletea-Marinescu-Valentin <pletea.valentin2003@gmail.com>
@Pletea-Marinescu-Valentin Pletea-Marinescu-Valentin force-pushed the feature/allow-dockerfile-jump branch from fc2309e to 752871d Compare April 26, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow jumping to a Dockerfile from a Compose file's dockerfile attribute inside the build specification
2 participants