Skip to content

Update BakeSchema to Support Both String and Object Types for 'Output' Attribute #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pletea-Marinescu-Valentin
Copy link

@Pletea-Marinescu-Valentin Pletea-Marinescu-Valentin commented Apr 25, 2025

This pull request updates the BakeSchema in the schema.go file to enhance the flexibility of the output attribute in the target block. The output attribute now supports both string values and objects with properties like type and dest. This change aligns the schema with the examples provided in the documentation and ensures compatibility with various use cases.
#77

Copy link
Collaborator

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pletea-Marinescu-Valentin Thank you for your interest in this project, Valentine! Please review our contribution guide. If you agree with what is written there, please amend your commits to make sure -s is used and force push back to your branch.

@Pletea-Marinescu-Valentin
Copy link
Author

I agree, i think i amended my commit with success. Can you check please if is everything ok?

@rcjsuen
Copy link
Collaborator

rcjsuen commented Apr 26, 2025

I agree, i think i amended my commit with success. Can you check please if is everything ok?

Your branch has not changed and your commit f5a685b is still what it was. One alternative is to just restart from scratch with a completely new commit and force push again.

@rcjsuen
Copy link
Collaborator

rcjsuen commented Apr 28, 2025

I see you have tried again but am still experiencing some issues. @Pletea-Marinescu-Valentin I suggest creating a new commit off of main, remembering to use git commit -s, and then force pushing that to this pull request. That might simplify things.

Signed-off-by: Pletea-Marinescu Valentin <125316206+Pletea-Marinescu-Valentin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants