Add support for the Zed editor

[ghuh]

Zed's docker extension currently uses https://github.com/rcjsuen/dockerfile-language-server
and Zed's compose extension currently uses https://github.com/microsoft/compose-language-service

It would be nice if Zed also supported the official docker-language-server. Zed only supports language servers through extensions so there is no way to manually add support. Either another extension needs to be added to Zed or the two extensions above need to be updated.

[rcjsuen]

@ghuh Thanks for raising this. I opened issues in both repositories previously (zed-extensions/dockerfile#22 and eth0net/zed-docker-compose#9) but there hasn't been any movement yet. I think we'll need to create our own pull request if we want to move forward with this.

[jclsn]

Instead of requesting support for a specific client, it might be more correct to request that they make the server fully LSP-conformant to support clients other than VSCode. I would assume that currently some special handlers would have to be defined in the LSP client to make the server fully operational.

[rcjsuen]

Instead of requesting support for a specific server, it might be more correct to request that they make the server fully LSP-conformant to support servers other than VSCode.

Hi @jclsn, did you mean to say "support clients other than Visual Studio Code"? I wasn't sure if you meant "Zed should make the client fully LSP compliant to support more servers" or "the Docker Language Server should be fully LSP compliant to support more clients".

I know that the Docker Language Server is used in JetBrains IDEs and Neovim so we do support clients other than Visual Studio Code. If you read something somewhere or found some code in the repository that is not compliant with the LSP specification, please let me know. Thanks!

[jclsn]

@rcjsuen Yes, you are right. I edited it :)

Well, I was just trying to get the server up and running in https://github.com/yegappan/lsp, but basic functionality is not there. It starts properly, but no hover or diagnostics are available. I assumed that the issue is the same as with Zed, although in the initial issue post it is not directly stated what exactly doesn't work with Zed.

My current config is and I have tested only for Dockerfile for now:

let docker_ls =
			\ #{name: 'docker-language-server',
			\   path: 'docker-language-server',
			\   args: ['start', '--stdio'],
			\   filetype: ['dockerfile'],
			\   debug: 'v:true'
			\ }

yegappan/lsp returns

Error detected while processing function <SNR>223_AsyncRpcCb[20]..<lambda>52:
line    1:
E1013: Argument 3: type mismatch, expected dict<any> but got special

I am assuming the RPC callback function is receiving a malformed object from the server, as I have not seen this error with any other server. dict<any> is what represents a JSON object in vimscript.

Not sure if this is the same error as with the Zed editor. Should I make a separate issue?

[rcjsuen]

Should I make a separate issue?

@jclsn Yes, please make a separate issue. Thank you.

[ghuh]

Instead of requesting support for a specific client, it might be more correct to request that they make the server fully LSP-conformant to support clients other than VSCode. I would assume that currently some special handlers would have to be defined in the LSP client to make the server fully operational.

This issue is specific to Zed because of the way the Zed extension system works. You can't just configure any LSP for use with Zed the way you can with an editor like Helix. The LSP specifically needs a Zed extension to wrap it.

So this ticket is to either update existing extensions or create new extensions so that Zed can actually use this LSP.

[ghuh]

It looks like Zed is going to support this now: zed-extensions/dockerfile#22 (comment)