Skip to content

fix: allow get_docker_configuration_file_args to parse minified json #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix: allow get_docker_configuration_file_args to parse minified json #525

merged 3 commits into from
Jun 2, 2023

Conversation

@brsolomon-deloitte
Copy link
Contributor

Closes #524.

@brsolomon-deloitte
Copy link
Contributor Author

I commited the deadly sin of piping cat to something here, but could not figure out how to use stdin redirection with that tr.

konstruktoid
konstruktoid requested changes Jun 2, 2023
View reviewed changes
@konstruktoid
Copy link
Collaborator

Thanks @brsolomon-deloitte!

@konstruktoid konstruktoid merged commit 1d29a1f into docker:master Jun 2, 2023
@brsolomon-deloitte brsolomon-deloitte deleted the bugfix/get_docker_configuration_file_args branch June 2, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstruktoid konstruktoid konstruktoid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in get_docker_configuration_file_args() causes false positives

2 participants

@brsolomon-deloitte @konstruktoid