Skip to content

Conversation

@denhamparry
Copy link
Contributor

@konstruktoid
Copy link
Collaborator

Thanks for this PR @denhamparry, I forgot to fix the Alpine Dockerfile when changing to bash.
My suggested change is instead:
ENTRYPOINT [ "/usr/bin/dumb-init", "/bin/sh", "docker-bench-security.sh" ]

- Set script to execute with sh rather than bash
- Set CMD Dockerfile to use /bin/sh
@denhamparry
Copy link
Contributor Author

Thanks for the review @konstruktoid 😄 I agree your suggestion is better and have tested it locally and it fixes the issue.

Updated the PR accordingly 👍

@konstruktoid
Copy link
Collaborator

Thanks for the update @denhamparry

@konstruktoid konstruktoid merged commit 2024e16 into docker:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bash not available within Alpine:3.13

2 participants