Skip to content

Reorder of sed command on images #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

Reorder of sed command on images #406

merged 1 commit into from
Dec 4, 2019

Conversation

@jammasterj89
Copy link
Contributor

@jammasterj89 jammasterj89 commented Dec 4, 2019 •
edited
Loading

@konstruktoid I've fixed the issue raised in the PR #390 in this PR.

@jammasterj89
Reorder of sed command on images
d2963b4 
Ensure sed command is first when filtering on images to ensure the description row is removed correctly.

Signed-off-by: Niall T <jammasterj89@gmail.com>
@jammasterj89 jammasterj89 mentioned this pull request Dec 4, 2019
Merged
@konstruktoid
Copy link
Collaborator

konstruktoid commented Dec 4, 2019 •
edited
Loading

Thanks @jammasterj89 and nice catch!

$ docker images | sed '1d' | grep "konstruktoid/docker-garby"
konstruktoid/docker-garby                            latest              14a4ce82964b        4 weeks ago         207MB
$ docker images | grep "konstruktoid/docker-garby" | sed '1d'
$

@konstruktoid konstruktoid merged commit c35d71f into docker:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jammasterj89 @konstruktoid