Dockerfile with docker-agent binary, keeping cagent only as compatible symlink#1992
Merged
dgageot merged 2 commits intodocker:mainfrom Mar 9, 2026
Merged
Dockerfile with docker-agent binary, keeping cagent only as compatible symlink#1992dgageot merged 2 commits intodocker:mainfrom
dgageot merged 2 commits intodocker:mainfrom
Conversation
…e symlink Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
gtardif
force-pushed
the
docker-agent_image
branch
from
1ac4d9a to
6c0e083
Compare
dgageot
previously approved these changes
Mar 9, 2026
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟡 NEEDS ATTENTION
Reviewed the Dockerfile changes for the binary rename from cagent to docker-agent. Found 1 issue requiring attention:
MEDIUM severity: The ldflags in the build command still reference the old module path github.com/docker/cagent/pkg/version. If the Go module has been renamed to match the binary, this will cause version information to be set incorrectly or the build may fail.
Statistics
- Files changed: 1
- Issues found: 1 (0 critical, 1 medium, 0 low)
- Issues verified: CONFIRMED
dgageot
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on cross will require changes on the release action