auto-complete tests

[gtardif]

No description provided.

[docker-agent]

Review Summary

Assessment: 🔴 CRITICAL

4 critical issues found - Index out of bounds vulnerabilities in test code

This PR adds autocomplete tests but contains critical bugs that will cause test panics if the autocomplete output doesn't match the expected format. All issues involve accessing slice indices without bounds checking after splitting stdout by newlines.

Critical Issues

The lines() helper function uses strings.Split(s, "\n"), which always returns at least a 1-element slice, but the tests access indices 1, 2, and 3 without verifying the slice has enough elements. If autocomplete returns fewer lines than expected, these tests will panic rather than fail gracefully.

Recommendation: Add length validation before accessing slice indices, for example:

props := lines(res.Stdout)
require.Len(t, props, 4, "expected 4 autocomplete options")
require.Contains(t, props[0], "a2a")
require.Contains(t, props[1], "acp")
require.Contains(t, props[2], "api")
require.Contains(t, props[3], "mcp")

Files Reviewed

• ✅ e2e/binary/shellout.go - No issues
• ❌ e2e/binary/binary_test.go - 4 critical issues

---

This review focuses only on bugs in the changed code. Style and existing code are not evaluated.