Skip to content

Fix gopls versions#1988

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:gopls-versions
Mar 9, 2026
Merged

Fix gopls versions#1988
dgageot merged 1 commit intodocker:mainfrom
dgageot:gopls-versions

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 9, 2026

No description provided.

@dgageot dgageot requested a review from a team as a code owner March 9, 2026 06:41
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

The changes in this PR are syntactically correct and make consistent updates to the gopls version across all affected configuration files. The version format golang/tools@v0.21.0 is properly structured for the MCP toolset configuration schema.

Note: This is a downgrade from v0.25.0 to v0.21.0 (4 minor versions back). While no bugs were found in the changed code itself, you may want to verify that:

  • v0.21.0 supports all Go language features currently in use
  • Any gopls-specific features or commands used by the agents are available in v0.21.0
  • The downgrade addresses a specific compatibility or stability issue

Files Reviewed

  • examples/gopher.yaml (2 occurrences updated)
  • examples/modernize-go-tests.yaml (1 occurrence updated)

Findings

No confirmed or likely bugs found in the changed code.


Review completed. All changes are syntactically valid.

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot merged commit d35bb70 into docker:main Mar 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants