Support comma-separated string for allowed-tools in skills#1984
Merged
rumpl merged 1 commit intodocker:mainfrom Mar 8, 2026
Merged
Support comma-separated string for allowed-tools in skills#1984rumpl merged 1 commit intodocker:mainfrom
rumpl merged 1 commit intodocker:mainfrom
Conversation
The allowed-tools field in skill frontmatter now accepts both a YAML list and a comma-separated string (e.g. "allowed-tools: Read, Grep"). This is done via a custom stringOrList type with UnmarshalYAML that first tries list parsing, then falls back to splitting a scalar string by commas. Assisted-By: cagent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
The implementation is solid overall. The custom stringOrList type correctly handles both YAML list and comma-separated string formats through a fallback UnmarshalYAML strategy. Test coverage is comprehensive with good edge cases.
One minor usability issue was identified regarding error messages when invalid YAML is provided.
Findings
1 low-severity issue found
rumpl
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowed-tools field in skill frontmatter now accepts both a YAML list and a comma-separated string (e.g. "allowed-tools: Read, Grep"). This is done via a custom stringOrList type with UnmarshalYAML that first tries list parsing, then falls back to splitting a scalar string by commas.
Assisted-By: cagent