Skip to content

A few more renames from cagent#1962

Merged
dgageot merged 8 commits intodocker:mainfrom
dgageot:rename-cagent
Mar 6, 2026
Merged

A few more renames from cagent#1962
dgageot merged 8 commits intodocker:mainfrom
dgageot:rename-cagent

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 6, 2026

No description provided.

dgageot added 8 commits March 6, 2026 11:42
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner March 6, 2026 10:50
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🔴 CRITICAL

Critical Issues Found: 2

This PR contains a systematic rename from cagent to docker-agent. However, there are critical inconsistencies in the renamed commands:

  • 2 files use docker agent (with space) instead of docker-agent (with hyphen)
  • These commands would invoke the Docker CLI with an agent subcommand (which doesn't exist) instead of the docker-agent binary
  • This will cause command failures in documentation examples and recording scripts

✅ Most renames are correct (using docker-agent with hyphen)
❌ Two files have incorrect spacing that will break commands


Review posted automatically by docker-agent PR reviewer

Set BorderRadius 10

Type "cagent run ./examples/pirate.yaml" Sleep 3s Enter
Type "docker agent run ./examples/pirate.yaml" Sleep 3s Enter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CRITICAL: Incorrect command syntax

This line uses docker agent run with a space between docker and agent. This will attempt to invoke the Docker CLI with an agent subcommand, which doesn't exist.

Fix: Change to docker-agent with a hyphen:

Type "docker-agent run ./examples/pirate.yaml" Sleep 3s Enter

The binary name is docker-agent (with hyphen), not docker agent (with space). This VHS recording script will fail without this correction.


```bash
cagent version
docker agent version
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CRITICAL: Incorrect command syntax

This line uses docker agent version with a space between docker and agent. This will attempt to invoke the Docker CLI with an agent subcommand, which doesn't exist.

Fix: Change to docker-agent with a hyphen:

docker-agent version

The binary name is docker-agent (with hyphen), not docker agent (with space). This command will fail as written.

@dgageot dgageot merged commit b8dffc1 into docker:main Mar 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants