Fix broken links in docs pages, were not using relative urls#1939
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 5, 2026
Merged
Fix broken links in docs pages, were not using relative urls#1939dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR correctly fixes broken documentation links by converting absolute URLs to Jekyll's relative_url filter. All 24 files follow the proper syntax pattern {{ '/path/' | relative_url }} and the changes are consistent throughout.
Summary:
- ✅ All URL conversions are syntactically correct
- ✅ Consistent pattern applied across all documentation files
- ✅ Appropriate solution for fixing 404s in GitHub Pages
- ✅ No runtime or logic errors detected
Findings
No issues found. The implementation is clean and follows Jekyll best practices for relative URL generation.
Review generated by docker-agent PR review
dgageot
approved these changes
Mar 5, 2026
aheritier
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 404 in many places in https://docker.github.io/cagent/
tested locally