Rename CAGENT_HIDE_TELEMETRY & CAGENT_EXP_DEBUG_LAYOUT. Still support old env vars#1926
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 5, 2026
Merged
Rename CAGENT_HIDE_TELEMETRY & CAGENT_EXP_DEBUG_LAYOUT. Still support old env vars#1926dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR successfully renames environment variables while maintaining backward compatibility:
CAGENT_HIDE_TELEMETRY_BANNER→DOCKER_AGENT_HIDE_TELEMETRY_BANNERCAGENT_EXPERIMENTAL_DEBUG_LAYOUT→DOCKER_AGENT_EXPERIMENTAL_DEBUG_LAYOUT
The implementation correctly uses logical OR operators to support both old and new variable names during the transition period. No functional bugs were found in the changed code.
Findings
No issues requiring changes. The backward compatibility logic is implemented correctly.
… old env vars Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
dgageot
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.