Skip to content

Remove --exit-on-stdin-eof#1918

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:stdin
Mar 4, 2026
Merged

Remove --exit-on-stdin-eof#1918
dgageot merged 1 commit intodocker:mainfrom
dgageot:stdin

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 4, 2026

No description provided.

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner March 4, 2026 13:25
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

This PR cleanly removes the --exit-on-stdin-eof flag and its associated functionality. The code review found:

Complete Removal: All related code has been properly removed:

  • Flag definition and initialization
  • monitorStdin goroutine function
  • Context cancellation wrapper
  • Associated test file (api_test.go)
  • Documentation references in TODO.md

No Resource Leaks: The simplified runAPICommand still properly uses cmd.Context() and maintains correct resource cleanup with existing defer statements.

No Breaking Changes: The removal doesn't introduce logic errors or leave orphaned code references.

The changes are safe and well-structured.


Automated review by cagent

@dgageot dgageot merged commit 63401a1 into docker:main Mar 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants