Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR cleanly removes the --exit-on-stdin-eof flag and its associated functionality. The code review found:
✅ Complete Removal: All related code has been properly removed:
- Flag definition and initialization
monitorStdingoroutine function- Context cancellation wrapper
- Associated test file (
api_test.go) - Documentation references in TODO.md
✅ No Resource Leaks: The simplified runAPICommand still properly uses cmd.Context() and maintains correct resource cleanup with existing defer statements.
✅ No Breaking Changes: The removal doesn't introduce logic errors or leave orphaned code references.
The changes are safe and well-structured.
Automated review by cagent
krissetto
approved these changes
Mar 4, 2026
trungutt
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.