Rename env vars CAGENT_ to DOCKER_AGENT_ (keep support for old env vars) #1917
Merged
gtardif merged 2 commits intodocker:mainfrom Mar 4, 2026
Merged
Rename env vars CAGENT_ to DOCKER_AGENT_ (keep support for old env vars) #1917gtardif merged 2 commits intodocker:mainfrom
gtardif merged 2 commits intodocker:mainfrom
Conversation
…ATEWAY Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
…T_MODEL Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR successfully renames environment variables from CAGENT_* to DOCKER_AGENT_* while maintaining backward compatibility. The implementation correctly implements a fallback chain (new env var → old env var → config file) for both MODELS_GATEWAY and DEFAULT_MODEL.
Changes reviewed:
- ✅ Backward compatibility fallback logic added in
cmd/root/flags.go - ✅ Tests updated to use new environment variable names
- ✅ Container evaluation logic updated in
pkg/evaluation/eval.go - ✅ Task file updated for test commands
Note: While the implementation is correct, the test suite could be enhanced by adding explicit test cases that verify the backward compatibility fallback (setting only CAGENT_* variables without DOCKER_AGENT_*). This would ensure the fallback mechanism continues to work in future refactorings.
Findings
No critical or notable issues found in the changed code.
Review performed by cagent PR review bot
dgageot
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.