Skip to content

Rename env vars CAGENT_ to DOCKER_AGENT_ (keep support for old env vars) #1917

Merged
gtardif merged 2 commits intodocker:mainfrom
gtardif:rename_env_vars
Mar 4, 2026
Merged

Rename env vars CAGENT_ to DOCKER_AGENT_ (keep support for old env vars) #1917
gtardif merged 2 commits intodocker:mainfrom
gtardif:rename_env_vars

Conversation

@gtardif
Copy link
Contributor

@gtardif gtardif commented Mar 4, 2026

No description provided.

gtardif added 2 commits March 4, 2026 12:52
…ATEWAY

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
…T_MODEL

Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
@gtardif gtardif requested a review from a team as a code owner March 4, 2026 12:04
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

This PR successfully renames environment variables from CAGENT_* to DOCKER_AGENT_* while maintaining backward compatibility. The implementation correctly implements a fallback chain (new env var → old env var → config file) for both MODELS_GATEWAY and DEFAULT_MODEL.

Changes reviewed:

  • ✅ Backward compatibility fallback logic added in cmd/root/flags.go
  • ✅ Tests updated to use new environment variable names
  • ✅ Container evaluation logic updated in pkg/evaluation/eval.go
  • ✅ Task file updated for test commands

Note: While the implementation is correct, the test suite could be enhanced by adding explicit test cases that verify the backward compatibility fallback (setting only CAGENT_* variables without DOCKER_AGENT_*). This would ensure the fallback mechanism continues to work in future refactorings.

Findings

No critical or notable issues found in the changed code.


Review performed by cagent PR review bot

@gtardif gtardif merged commit 7d3de78 into docker:main Mar 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants