update taskfile to build both images docker/cagent and docker/docker-agent#1916
Merged
gtardif merged 1 commit intodocker:mainfrom Mar 4, 2026
Merged
update taskfile to build both images docker/cagent and docker/docker-agent#1916gtardif merged 1 commit intodocker:mainfrom
gtardif merged 1 commit intodocker:mainfrom
Conversation
…agent Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
The changes correctly add a second tag (docker/docker-agent) to both Docker image build tasks. The docker buildx build command properly supports multiple -t flags, and the implementation is functionally correct.
Note: There's a minor stylistic inconsistency (extra space before {{.BUILD_ARGS}} in the push-image task on line 89), but this does not affect functionality.
No bugs found in changed code.
trungutt
approved these changes
Mar 4, 2026
aheritier
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.