Merged
Conversation
The sandbox property belongs to the shell toolset, not the agent. Updated all documentation examples to nest sandbox under '- type: shell' instead of placing it at the agent level. Removed the sandbox row from the agent properties reference table. Fixes docker#1882 Assisted-By: cagent
Signed-off-by: David Gageot <david.gageot@docker.com>
There was a problem hiding this comment.
Review Summary
This PR updates the documentation to reflect a configuration restructure:
- Moves
deferfrom agent-level to toolset-level - Moves
sandboxfrom agent-level to toolset-level (under shell toolset) - Moves
permissionsfrom agent-level to global-level
All examples have been updated consistently across the documentation files. The YAML structure, tool naming conventions, and indentation are correct. No issues found.
aheritier
approved these changes
Mar 3, 2026
trungutt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.