Merged
Conversation
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
There was a problem hiding this comment.
Review Summary
✅ APPROVED - No issues found.
This PR adds a straightforward fix to detect when cagent is invoked standalone by the Docker AI CLI plugin. The change adds an additional condition rootCmd.Name() == "cagent" to the existing plugin.RunningStandalone() check, which correctly handles the edge case described in the PR description.
The logic is sound:
- When
docker aishells out tocagent, the environment variables indicate it's running as a plugin, butcagentshould still run in standalone mode - The OR condition ensures both scenarios are covered
- No nil pointer risks, logic errors, or other issues identified
The code change is minimal, focused, and achieves the stated goal without introducing new vulnerabilities.
rumpl
approved these changes
Feb 26, 2026
dgageot
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect when
cagent(standalone invocation) is invoked by a cli plugin, and run cagent standalone, not as a cli plugin