Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds security improvements for path traversal protection in the filesystem toolset and improves error logging. However, there is one issue that should be addressed: the path validation logic doesn't account for case-insensitive filesystems (Windows and macOS), which could potentially allow path traversal attacks on those platforms.
Add path validation to handleReadFile, handleWriteFile, and handleEditFile in the ACP filesystem toolset. User-supplied paths are now resolved and validated to ensure they do not escape the configured working directory. Previously, paths like '../../etc/passwd' could be used to access files outside the working directory. The new resolvePath method converts paths to absolute form and checks they remain within the working directory boundary. Fixes docker#1823 Assisted-By: cagent
The persistSessionTitle function silently discarded errors from UpdateSessionTitle (other than ErrTitleGenerating). Add slog.Warn so failures are visible in debug logs. Fixes docker#1821 Assisted-By: cagent
Signed-off-by: David Gageot <david.gageot@docker.com>
Contributor
|
/describe |
krissetto
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.