fix(editor): prevent thread block when attachment file is deleted#1736
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 6, 2026
Merged
fix(editor): prevent thread block when attachment file is deleted#1736dgageot merged 1 commit intodocker:mainfrom
dgageot merged 1 commit intodocker:mainfrom
Conversation
krissetto
previously requested changes
Feb 18, 2026
Contributor
krissetto
left a comment
krissetto
left a comment
There was a problem hiding this comment.
same with other comments, sorry ;) if the code is self explanatory, comments are extra things to maintain
Contributor
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
Done, I totally agree :) @krissetto |
Assisted-By: cagent
dgageot
force-pushed
the
bugfix/file-delete-thread-block
branch
from
b2907a3 to
a87abd4
Compare
dgageot
approved these changes
Mar 6, 2026
trungutt
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Releated Issue