Conversation
Go released 1.18.6 + 1.19.1 today which fix a couple CVEs. (`golang.org/x/net` also has a related fix.) This jumps from 1.18.5 -> 1.19.1 since it was on the to-do list regardless :) Signed-off-by: Milas Bowman <milas.bowman@docker.com>
| default: "false" | ||
|
|
||
| env: | ||
| GO_VERSION: "1.18.5" # for non sandboxed e2e tests |
There was a problem hiding this comment.
Note that the release pipeline is still on 1.18; does the CI matrix also test against that version?
There was a problem hiding this comment.
The release pipeline in docker/docker-ce-packaging, right? (IIRC we settled on it calls make build from the Makefile in this repo, which does a "local" go build inside of its container but not using buildx bake for the actual Compose build)
How do we generally handle that for other projects packaged by it? Something like this?
- Upgrade project CI to default to Go
n+1 - Continue running project CI against Go
n&n+1 - Once all projects on Go
n+1, change packaging to use Gon+1 - Drop Go
nfrom project CI
cc @glours if you have opinions
|
You'll have to update golangci-lint to v1.49 probably; note that there's some linters being deprecated (and/or replaced); docker/cli#3768 |
Need a compatible version for 1.19 Signed-off-by: Milas Bowman <milas.bowman@docker.com>
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
| go-version-file: 'go.mod' |
There was a problem hiding this comment.
Reading minds! I was about to make this change!
What I did
Go released 1.18.6 + 1.19.1 today which fix a couple CVEs. (
golang.org/x/netalso has a related fix.)This jumps from 1.18.5 -> 1.19.1 since it was on the to-do list regardless :)
Related issue
https://groups.google.com/g/golang-announce/c/x49AQzIVX-s
(not mandatory) A picture of a cute animal, if possible in relation with what you did
