build full compose model from resources, then filter by services #9250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
requested review from
glours and
ulyssessouza
and removed request for
glours
ndeloof
force-pushed
the
stop_9241
branch
3 times, most recently
from
0032d95
to
d9c6a0d
Compare
ndeloof
commented
Mar 9, 2022
ndeloof
force-pushed
the
stop_9241
branch
5 times, most recently
from
07a67f7
to
1ce67e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
introduced
actualState(this reduces code duplication and risk to have same bug in other places) to list resources, rebuild compose project model, then filter by requested servicesfix
docker compose stop SERVICEwith reference to other dependenciesbonus:
docker compose rmdoesn't need a compose file anymoreincludes e2e test so we get rid of this bug and don't need yet another patch release🤞
Related issue
closes #9241
closes #9249
(not mandatory) A picture of a cute animal, if possible in relation with what you did