Don't wait forever for unhealthy dependencies#9092
Merged
Conversation
ndeloof
approved these changes
Jan 7, 2022
Contributor
|
for legal reasons we require commits to be signed-off. |
The previous code would wait for dependencies to become healthy forever, even if they'd become unhealthy in the meantime. I can't find an issue report for this bug, but it was described in a comment on the PR that introduced the `--wait` flag [0]. [0]: docker#8777 (comment) Signed-off-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Contributor
Author
|
Whoops, sorry! I'm not in the habit. Fixed now. |
|
What should I do to revert to the previous behavior? I have an Oracle container which can take since 2-10 minutes to become healthy, which includes some time during unhealthy state. I had a pipeline which relied on that behavior, and since I upgraded the docker-compose, it stopped working because of this. |
|
Nevermind. I think the correct thing to do is to adjust the healthcheck so that it does not report as unhealthy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ndeloof I've got one more
--wait-related fix for you here. Does the test case look ok?What I did
The previous code would wait for dependencies to become healthy forever,
even if they'd become unhealthy in the meantime. I can't find an issue
report for this bug, but it was described in a comment on the PR that
introduced the
--waitflag 0.