(refactoring) introduce monitor to manage containers events and application termination #12906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
refactoring:
monitor
to dispatch container events and manage application terminationwatchcontainer
relying on event dispatch, removed fromstart
andlog
printer
only focus on rendering application status, not trying to detect termination - uses explicit terminationpresenter
(color) inprinter
. Will be set on first use.improvement (2nd commit):
collecting start event, capture container's StartTime. This is used to collect logs using log API (we are too late to attach) and retrieve the very first logs. Tested using:
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
