Add unit tests to plugin create/remove/enable/disable commands #878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 53.19% 52.67% -0.52%
==========================================
Files 246 257 +11
Lines 16021 16403 +382
==========================================
+ Hits 8522 8640 +118
- Misses 6929 7190 +261
- Partials 570 573 +3 |
cli/command/plugin/create_test.go
Outdated
| err = setupPluginDir(tmpDir, []byte("invalid-config-contents")) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
This can be do with (gotestyourself/fs):
tmpDir := fs.NewDir(t, "plugin-create-test",
fs.WithDir("rootfs",
fs.WithFile("config.json", "invalid-config-contents")))
defer tmpDir.Remove()Just as an FYI, I think this works for now.
There was a problem hiding this comment.
Thank you for the review. The gotestyourself looks very interesting (just taking a look at the above example, it reads much better than the function I wrote for these tests).
If you are OK with such a change, I can change to use gotestyourself/fs here.
There was a problem hiding this comment.
That would be great, thanks!
cli/command/plugin/create_test.go
Outdated
| cmd := newCreateCommand(cli) | ||
| cmd.SetArgs([]string{"plugin-foo", tmpDir}) | ||
| assert.NoError(t, cmd.Execute()) | ||
| assert.Equal(t, "plugin-foo", strings.TrimSpace(cli.OutBuffer().String())) |
There was a problem hiding this comment.
I think we should check the stdout without TrimSpace(). The trailing newline is important.
There's a few instances of this below as well.
There was a problem hiding this comment.
Thanks for the review. I have updated the PR accordingly.
…rk on docker#37 Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
adshmh
force-pushed
the
add-unit-tests-to-plugin-package
branch
from
e147ce2
to
0a914da
Compare
add tests to plugin create/remove/enable/disable commands. Part of work on #37
Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com
- What I did
Added unit tests to several plugin commands (create/remove/enable/disable)
- How I did it
Added tests in create_test.go, remove_test.go, enable_test.go, disable_test.go
- How to verify it
Run the test suite:
make -f docker.Makefile test
- Description for the changelog
Added unit tests to plugin create/remove/enable/disable commands.
- A picture of a cute animal (not mandatory but encouraged)