Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix-matching for service ps #72

Merged
merged 3 commits into from
Jun 13, 2017

Commits on May 31, 2017

  1. Fix prefix-matching for service ps

    The docker CLI matches objects either by ID _prefix_
    or a full name match, but not partial name matches.
    
    The correct order of resolution is;
    
    - Full ID match (a name should not be able to mask an ID)
    - Full name
    - ID-prefix
    
    This patch changes the way services are matched.
    
    Also change to use the first matching service, if there's a
    full match (by ID or Name) instead of continue looking for
    other possible matches.
    
    Error handling changed;
    
    - Do not error early if multiple services were requested
      and one or more services were not found. Print the
      services that were not found after printing those that
      _were_ found instead
    - Print an error if ID-prefix matching is ambiguous
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed May 31, 2017
    Configuration menu
    Copy the full SHA
    6279612 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2017

  1. Fix complexity of service/ps.

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    dnephin committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    b5baffd View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. Add unit tests for service/ps

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    dnephin committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    3718833 View commit details
    Browse the repository at this point in the history