cli/command/registry: refactor reading from stdin #6797
+76
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR refactors the password reading logic in the Docker CLI's registry login command by extracting it into a standalone utility function with comprehensive documentation.
Changes:
- Extracted password/secret reading logic from stdin into a new
readSecretFromStdinutility function - Added detailed GoDoc documentation explaining the line-ending trimming behavior and NIST compliance
- Updated imports: added
bytespackage (forbytes.CutSuffix), removed unusedstringspackage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Extract the code as a utility function, and add some GoDoc to describe the behavior. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
login_stdin_refactor
branch
from
2a99b14 to
61f03db
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the code as a utility function, and add some GoDoc to describe the behavior.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)