Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 3, 2025

@dvdksn dvdksn requested review from a team and thaJeztah as code owners November 3, 2025 10:19
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

The network driver protocol, in addition to the plugin activation call, is
documented as part of libnetwork:
[https://github.com/moby/moby/blob/master/libnetwork/docs/remote.md](https://github.com/moby/moby/blob/master/libnetwork/docs/remote.md).
[https://github.com/moby/libnetwork/blob/master/docs/remote.md](https://github.com/moby/libnetwork/blob/master/docs/remote.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moby/libnetwork is the old repository, so we probably shouldn't link there, but not sure if the current location of these is correct if they are meant to be publicly facing
https://github.com/moby/moby/tree/ada61040e00f25ab7c326561159cf59090d7d2a3/daemon/libnetwork/docs

cc @robmry @akerouanton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the links got broken when we moved libnetwork under daemon - so linking to there (rather than the old libnetwork repo) would restore what was there before. I don't think we have any other documentation for remote network drivers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see - linking there instead then. And dropping the last section of this doc...

@dvdksn dvdksn force-pushed the update-libnetwork-docs-link branch from ed0698b to d51f351 Compare November 3, 2025 12:32
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the update-libnetwork-docs-link branch from d51f351 to aa62a6a Compare November 3, 2025 12:32
@dvdksn dvdksn changed the title docs: update links to libnetwork docs docs: update link to libnetwork protocol doc Nov 3, 2025
Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 29.0.0 milestone Nov 6, 2025
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit c4f240c into docker:master Nov 7, 2025
170 of 171 checks passed
@dvdksn dvdksn deleted the update-libnetwork-docs-link branch November 7, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants