-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: update link to libnetwork protocol doc #6606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docs/extend/plugins_network.md
Outdated
| The network driver protocol, in addition to the plugin activation call, is | ||
| documented as part of libnetwork: | ||
| [https://github.com/moby/moby/blob/master/libnetwork/docs/remote.md](https://github.com/moby/moby/blob/master/libnetwork/docs/remote.md). | ||
| [https://github.com/moby/libnetwork/blob/master/docs/remote.md](https://github.com/moby/libnetwork/blob/master/docs/remote.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moby/libnetwork is the old repository, so we probably shouldn't link there, but not sure if the current location of these is correct if they are meant to be publicly facing
https://github.com/moby/moby/tree/ada61040e00f25ab7c326561159cf59090d7d2a3/daemon/libnetwork/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the links got broken when we moved libnetwork under daemon - so linking to there (rather than the old libnetwork repo) would restore what was there before. I don't think we have any other documentation for remote network drivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see - linking there instead then. And dropping the last section of this doc...
ed0698b to
d51f351
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
d51f351 to
aa62a6a
Compare
robmry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com