Skip to content

Conversation

thaJeztah
Copy link
Member

vendor: github.com/docker/go-connections v0.6.0

  • deprecate sockets.GetProxyEnv, sockets.DialerFromEnvironment
  • add support for unix sockets on Windows
  • remove legacy CBC cipher suites from client config
  • align client and server defaults to be the same.
  • remove support for encrypted TLS private keys.
  • nat: optimize ParsePortSpec

full diff: docker/go-connections@v0.5.0...v0.6.0

(cherry picked from commit 3529651)

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

Remove support for legacy CBC cipher suites

- A picture of a cute animal (not mandatory but encouraged)

- deprecate sockets.GetProxyEnv, sockets.DialerFromEnvironment
- add support for unix sockets on Windows
- remove legacy CBC cipher suites from client config
- align client and server defaults to be the same.
- remove support for encrypted TLS private keys.
- nat: optimize ParsePortSpec

full diff: docker/go-connections@v0.5.0...v0.6.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 3529651)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah
Copy link
Member Author

Hm.. interesting failure; perhaps needs some additional error handling somewhere

#18 64.44 === Failed
#18 64.44 === FAIL: cli/command/container TestRunPullTermination (0.01s)
#18 64.44     run_test.go:252: assertion failed: error is not nil: io: read/write on closed pipe

@thaJeztah
Copy link
Member Author

FWIW; I was considering if dropping the legacy/insecure CBC ciphers should wait, but I noticed that compose already updated this dependency, and AFAIK, there's been no issue reported related to dropping those, so probably fine to include 😅

@thaJeztah thaJeztah requested a review from vvoland September 24, 2025 12:07
@austinvazquez austinvazquez merged commit 67885d0 into docker:28.x Sep 24, 2025
101 of 102 checks passed
@thaJeztah thaJeztah deleted the 28.x_backport_bump_go_connections branch September 24, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants