image/tree: Print longest names first and use full width #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5757 +/- ##
==========================================
- Coverage 59.47% 59.45% -0.02%
==========================================
Files 346 346
Lines 29367 29376 +9
==========================================
Hits 17465 17465
- Misses 10929 10938 +9
Partials 973 973 |
Benehiko
approved these changes
Jan 20, 2025
When printing image names, sort them by length and print the longest first. This also allows them to use a full terminal width because they are not printed alongside other columns. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
images-tree-name
branch
from
708b732 to
26010e4
Compare
Benehiko
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing image names, sort them by length and print the longest first. This also allows them to use a full terminal width because they are not printed alongside other columns.
Before
After
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)