Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5387 +/- ##
==========================================
- Coverage 60.94% 59.70% -1.25%
==========================================
Files 304 345 +41
Lines 21346 23382 +2036
==========================================
+ Hits 13010 13960 +950
- Misses 7407 8452 +1045
- Partials 929 970 +41 |
thaJeztah
force-pushed
the
update_go_1.22
branch
from
4f6e41b to
83f0f1a
Compare
Member
Author
|
Ah; this is failing now on linux/arm/v6, linux/arm/v7, linux/riscv64, linux/s390x; related to #5388 (review) |
thaJeztah
commented
Sep 2, 2024
scripts/build/plugins
Outdated
|
|
||
| echo "Building $GO_LINKMODE $(basename "${TARGET_PLUGIN}")" | ||
| (set -x ; CGO_ENABLED=0 GO111MODULE=auto go build -o "${TARGET_PLUGIN}" -tags "${GO_BUILDTAGS}" -ldflags "${GO_LDFLAGS}" ${GO_BUILDMODE} "github.com/docker/cli/${p}") | ||
| (set -x ; CGO_ENABLED=0 GO111MODULE=auto go build -o "${TARGET_PLUGIN}" -tags "${GO_BUILDTAGS}" -ldflags "${GO_LDFLAGS}" "github.com/docker/cli/${p}") |
Member
Author
There was a problem hiding this comment.
Wondering if instead, this should be removing the CGO_ENABLED=0 (similar to how we handle the main binary); that said, I don't think we need CGO here for the plugin (maybe for the -X flags?)
thaJeztah
force-pushed
the
update_go_1.22
branch
4 times, most recently
from
83da7d3 to
69f650d
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_go_1.22
branch
from
69f650d to
d7d5659
Compare
vvoland
approved these changes
Sep 3, 2024
1 task
This was referenced Sep 4, 2024
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)