Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0] vendor: github.com/docker/docker 25.0.4-51e876cd964c4bb1f0a7c1bc24ecab9321b3ff1c #4908

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Mar 4, 2024

full diff: moby/moby@v25.0.3...51e876c

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland added this to the 25.0.4 milestone Mar 4, 2024
@vvoland vvoland self-assigned this Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Merging #4908 (0735e78) into 25.0 (08eba22) will increase coverage by 0.01%.
Report is 15 commits behind head on 25.0.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             25.0    #4908      +/-   ##
==========================================
+ Coverage   61.32%   61.34%   +0.01%     
==========================================
  Files         287      287              
  Lines       20071    20088      +17     
==========================================
+ Hits        12309    12322      +13     
- Misses       6869     6871       +2     
- Partials      893      895       +2     

@thaJeztah thaJeztah changed the title vendor: github.com/docker/docker 25.0.4-51e876cd964c4bb1f0a7c1bc24ecab9321b3ff1c [25.0] vendor: github.com/docker/docker 25.0.4-51e876cd964c4bb1f0a7c1bc24ecab9321b3ff1c Mar 4, 2024
vendor.mod Outdated
github.com/docker/docker v25.0.3+incompatible
github.com/docker/docker v25.0.4-0.20240301160236-51e876cd964c+incompatible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps good to add a comment here to indicate where this version came from, e.g. something like;

// 25.0 branch (v25.0.4-dev)

full diff: moby/moby@v25.0.3...51e876c

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should consider doing another update once all backports in moby/moby are merged, so that (ideally) the commit will be matching the one that's used for the actual v25.0.4 release.

@thaJeztah thaJeztah merged commit 2bf4225 into docker:25.0 Mar 5, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants