Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: remove printServerWarningsLegacy #4808

Merged
merged 1 commit into from
Jan 23, 2024

Commits on Jan 20, 2024

  1. info: remove printServerWarningsLegacy

    Docker Engine 18.09 (API v1.39) introduced a Warnings field in the into response.
    This enhancement was not gated by API version (see [moby/moby@a3d4238]), and
    will be returned by Docker Engine 18.09 and up, regardless of the API version
    chosen.
    
    Likewise, the client-side code was written to prefer warnings returned by
    the daemon, but to fall back on client-side detection of missing features
    based on information in the Info response (see [docker/cli@3c27ce2]).
    
    Thse warnings are purely informational, and given that Docker Engine versions
    before 18.09 have reached EOL 6 Years ago, and any current version of the
    Engine now returns the Warnings, it should be safe to remove the client-side
    fall back logic.
    
    This patch removes the client-side fall back code for warnings that was
    added in 3c27ce2.
    
    [moby/moby@a3d4238]: moby/moby@a3d4238
    [docker/cli@3c27ce2]: docker@3c27ce2
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    a71d39b View commit details
    Browse the repository at this point in the history