docs: fix broken links to alias pages #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alias pages redirect to the canonical names, but these pages still linked to the aliases, causing broken links when building the docs site. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4800 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 287 287
Lines 24777 24777
=======================================
Hits 14775 14775
Misses 9114 9114
Partials 888 888 |
CLI reference for the base command was generated to cli.md Changed it to docker.md to handle broken links. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
docs-fix-broken-alias-links
branch
from
9610e21
to
d633890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias pages redirect to the canonical names, but these pages still
linked to the aliases, causing broken links when building the docs site.
Also moved the CLI reference for the docker base command from
cli.mdtodocker.mdand disabled workaround for regenerating the CLI reference to the non-canonical page.Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)