Support for rollback config in compose 3.7#409
Conversation
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage ? 50.52%
=========================================
Files ? 216
Lines ? 17724
Branches ? 0
=========================================
Hits ? 8955
Misses ? 8321
Partials ? 448 |
|
anything blocking this? |
|
@alshabib Any chance you could update this PR so it might make it into spec version 3.5? |
|
Sure. Just pushed an update. |
|
This needs to be moved to version 3.5 schema now, otherwise LGTM |
|
is this in 3.5 already ? and does the |
|
@thaJeztah rebased, fixed conflicts and update to be on composefile 3.7 👼 |
cfe0a96 to
6d966fc
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
saw one thing, LGTM otherwise
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
we need a procedure to "stage" upcoming compose file changes (ie the 3.7 schema should be considered -dev until it's released)
Fixes moby/moby#32585
- What I did
Built off #360 to provide support for rollback config in compose 3.4. ie.
- How I did it
Added the key to the schema, regenerated the schema and tied it to existing UpdateConfig type.
- How to verify it
with the following stack:
- Description for the changelog
This pull request adds support for rollback configurations to be specified in the YAML stack file. Given that it is build off the aforementioned pull request, it supports also rollback_config.order.
- A picture of a cute animal (not mandatory but encouraged)