format (GoDoc) comments with Go 1.19 to prepare for go updates#3708
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jul 19, 2022
Merged
format (GoDoc) comments with Go 1.19 to prepare for go updates#3708thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3708 +/- ##
=======================================
Coverage 59.06% 59.06%
=======================================
Files 289 289
Lines 24673 24673
=======================================
Hits 14573 14573
Misses 9226 9226
Partials 874 874 |
thaJeztah
commented
Jul 13, 2022
cli/compose/loader/merge.go
Outdated
| } | ||
|
|
||
| //nolint: unparam | ||
| // nolint: unparam |
Member
Author
There was a problem hiding this comment.
FWIW; opened a bug-report in Golang for these; golang/go#53835
thaJeztah
force-pushed
the
gofmt_119
branch
3 times, most recently
from
e893f1d to
0a41850
Compare
Older versions of Go do not format these comments, so we can already
reformat them ahead of time to prevent gofmt linting failing once
we update to Go 1.19 or up.
Result of:
gofmt -s -w $(find . -type f -name '*.go' | grep -v "/vendor/")
With some manual adjusting.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
rumpl
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Go do not format these comments, so we can already
reformat them ahead of time to prevent gofmt linting failing once
we update to Go 1.19 or up.
Result of:
With some manual adjusting.