Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
Coverage ? 46.14%
=========================================
Files ? 193
Lines ? 16073
Branches ? 0
=========================================
Hits ? 7417
Misses ? 8269
Partials ? 387 |
dnephin
force-pushed
the
improve-makefile-bash
branch
2 times, most recently
from
bf04f4a to
896f939
Compare
dnephin
force-pushed
the
improve-makefile-bash
branch
from
896f939 to
47694f6
Compare
Contributor
Author
|
ping again |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Use ./tasks in circleci List task targets with './tasks --help' Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
improve-makefile-bash
branch
2 times, most recently
from
73e1437 to
f80248d
Compare
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Collaborator
|
ping @dnephin should we close this one for now ? |
Contributor
Author
|
I still think this is a better solution. If we close it we should have some reason for closing it. I'd like to see some arguments for why the Makefile is a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #99
(replaces #107 which seemed to be bugged, github was not triggering any webhooks for that PR)
Replace the
.PHONYMakefile with a bash script which does a lot more than the original Makefile. This bash script will allow the addition of new targets to theMakefilewithout having to touch./tasks. Allows us to use the same script for DEV and CI, and adds support for different workflows.shellprompts are provided to all images without any additional configuration.I don't necessarily think this is the best solution, but I think it's an improvement over the Makefile.