Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: add build.extra_hosts to v3.9 schema #2517

Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented May 10, 2020

fixes #1293

This is not currently used by the CLI, but can be used by docker compose to bring parity on this feature with the compose v2.4 schema.

relates to docker/compose#7323

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

@silvin-lubecki @ndeloof PTAL

This is not currently used by the CLI, but can be used by
docker compose to bring parity on this feature with the
compose v2.4 schema.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the compose_file_build_extra_hosts branch from f37a81b to 0c5f97e Compare May 10, 2020 18:01
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit ce2a9fa into docker:master May 11, 2020
@thaJeztah thaJeztah deleted the compose_file_build_extra_hosts branch May 11, 2020 15:20
@ndeloof
Copy link
Contributor

ndeloof commented May 11, 2020

Compose canonical schema should be https://github.com/compose-spec/compose-spec/blob/master/schema/config_schema_v3.9.json and such change should only take place after a public proposal to the compose-spec community.

Please note re-introducing v2 attributes has been discussed on compose-spec/compose-spec#12

@thaJeztah
Copy link
Member Author

@ndeloof what I understood is that the current 3.9 spec was used as the transition to make compose-spec the canonical place because it was already worked on for the upcoming 20.03 release; if compose-spec is the canonical place, should this repository vendor the spec from that location? (also this means we have a release blocker for 20.03, pending #2503

@agners
Copy link

agners commented May 14, 2020

@thaJeztah @ndeloof this is utterly frustrating for outside contributors. I created a merge request months ago adding device_cgroup_rules (see #2206). However it got ignored/sidelined. With the compose-spec comming along, I did all my home work and helped making it part of the upcoming spec compose-spec/compose-spec#63.

And now, within 4 days other properties make it in directly into CLI's compose spec? So now compose-spec essentially forked??

@ndeloof
Copy link
Contributor

ndeloof commented May 14, 2020

https://github.com/compose-spec/compose-go is the exact same codebase as docker/cli for compose file loading and mdel (this is a git extract, including history). CLI should be updated to adopt compose-go and throw avoid code to diverge like this. This is more a question of finding the right timing vs CLI release schedule.

@agners
Copy link

agners commented Jun 19, 2020

@ndeloof @thaJeztah since we won't adopt compose-go in time for 20.03, could we then not just merge #2206? I would mean less divergence from compose-spec...

@ndeloof
Copy link
Contributor

ndeloof commented Jun 19, 2020

compose-spec is going to re-introduce all v2 attributes in the schema by approval of compose-spec/compose-spec#12
so #2206 still make sense, this won't introduce a divergence.

@burka
Copy link

burka commented May 14, 2024

For anyone searching like me: It's solved in Version 3.9 #2517 - you can add extra_hosts: in build: now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build-time extra_hosts for Version 3
5 participants